Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ordering problem in add or renew lease test #38280

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Fix ordering problem in add or renew lease test #38280

merged 1 commit into from
Feb 3, 2019

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented Feb 3, 2019 •
edited
Loading

We have to set the primary term before we add a retention lease, otherwise we can not assert the correct primary term.

Closes #38245
Relates #38275

@jasontedor
Fix ordering problem in add or renew lease test
15c199e 
We have to set the primary term before we add a retention lease,
otherwise we can not assert the correct primary term.
@jasontedor jasontedor added >test-failure Triaged test failures from CI v7.0.0 :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.7.0 labels Feb 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@jasontedor jasontedor mentioned this pull request Feb 3, 2019
Merged
dnhatn
dnhatn approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor jasontedor merged commit d2cc145 into elastic:master Feb 3, 2019
@jasontedor jasontedor deleted the add-or-renew-ordering-fix branch February 3, 2019 17:54
@jasontedor jasontedor mentioned this pull request Feb 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test-failure Triaged test failures from CI v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasontedor @elasticmachine @dnhatn @colings86